> On Nov. 9, 2015, 1:54 p.m., Till Toenshoff wrote:
> > 3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp, line 130
> > <https://reviews.apache.org/r/39594/diff/2/?file=1117991#file1117991line130>
> >
> >     Add blank line here please.

I would be happy to oblige, but that wouldn't commit due cpplint,

    Redundant blank line at the start of a code block should be deleted.  
[whitespace/blank_line] [2]


> On Nov. 9, 2015, 1:54 p.m., Till Toenshoff wrote:
> > 3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp, line 141
> > <https://reviews.apache.org/r/39594/diff/2/?file=1117991#file1117991line141>
> >
> >     Why not use `nullptr` instead?
> 
> Jan Schlicht wrote:
>     Is `nullptr` okay to use? Judging from MESOS-3243 I'd say that it's not 
> there yet. Also there's no mention of it in the C++ style guide.
> 
> Benjamin Bannier wrote:
>     I would have commented that since this file completely relies on `NULL` 
> instead of `nullptr` already consistence would suggest to stick to `NULL`.
> 
> Till Toenshoff wrote:
>     I would interpret MESOS-3243 as a transition ticket for old, existing 
> code and not for new code.

No problem, I `nullptr`ized that instance, but left the others for the 
automatic cleanup.


- Benjamin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39594/#review105488
-----------------------------------------------------------


On Nov. 10, 2015, 1:45 p.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39594/
> -----------------------------------------------------------
> 
> (Updated Nov. 10, 2015, 1:45 p.m.)
> 
> 
> Review request for mesos, Bernd Mathiske, Jan Schlicht, and Till Toenshoff.
> 
> 
> Bugs: MESOS-3785
>     https://issues.apache.org/jira/browse/MESOS-3785
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> [stout]: Added function to simultaneously query size and mtime of URI.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/fs.hpp 
> 311b00b41398a9fd7374f3847190468ba59c1dc9 
>   3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp 
> e49783a438157706b1be9745436bf666f45cab8b 
> 
> Diff: https://reviews.apache.org/r/39594/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Reply via email to