> On Nov. 9, 2015, 1:54 p.m., Till Toenshoff wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp, line 141 > > <https://reviews.apache.org/r/39594/diff/2/?file=1117991#file1117991line141> > > > > Why not use `nullptr` instead? > > Jan Schlicht wrote: > Is `nullptr` okay to use? Judging from MESOS-3243 I'd say that it's not > there yet. Also there's no mention of it in the C++ style guide.
I would have commented that since this file completely relies on `NULL` instead of `nullptr` already consistence would suggest to stick to `NULL`. - Benjamin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39594/#review105488 ----------------------------------------------------------- On Nov. 6, 2015, 7:52 p.m., Benjamin Bannier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39594/ > ----------------------------------------------------------- > > (Updated Nov. 6, 2015, 7:52 p.m.) > > > Review request for mesos, Bernd Mathiske, Jan Schlicht, and Till Toenshoff. > > > Bugs: MESOS-3785 > https://issues.apache.org/jira/browse/MESOS-3785 > > > Repository: mesos > > > Description > ------- > > [stout]: Added function to simultaneously query size and mtime of URI. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/include/stout/fs.hpp > 311b00b41398a9fd7374f3847190468ba59c1dc9 > 3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp > e49783a438157706b1be9745436bf666f45cab8b > > Diff: https://reviews.apache.org/r/39594/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Benjamin Bannier > >
