-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39400/#review105817
-----------------------------------------------------------



src/master/allocator/mesos/hierarchical.hpp (line 358)
<https://reviews.apache.org/r/39400/#comment164474>

    s/the/this



src/master/allocator/mesos/hierarchical.hpp (line 359)
<https://reviews.apache.org/r/39400/#comment164476>

    Quota is satisfied before fair share, ...



src/master/allocator/mesos/hierarchical.cpp (line 137)
<https://reviews.apache.org/r/39400/#comment164477>

    `Resources`



src/master/allocator/mesos/hierarchical.cpp (line 416)
<https://reviews.apache.org/r/39400/#comment164479>

    `resources`



src/master/allocator/mesos/hierarchical.cpp (line 581)
<https://reviews.apache.org/r/39400/#comment164480>

    `resources`



src/master/allocator/mesos/hierarchical.cpp (line 893)
<https://reviews.apache.org/r/39400/#comment164481>

    s/numbers/numbers.



src/master/allocator/mesos/hierarchical.cpp (line 924)
<https://reviews.apache.org/r/39400/#comment164482>

    Do you want to -symetrically to your todu when setting quota- print the 
actual quota removed?


- Joerg Schad


On Nov. 5, 2015, 6:25 p.m., Alexander Rukletsov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39400/
> -----------------------------------------------------------
> 
> (Updated Nov. 5, 2015, 6:25 p.m.)
> 
> 
> Review request for mesos, Bernd Mathiske, Joerg Schad, Joris Van Remoortere, 
> and Joseph Wu.
> 
> 
> Bugs: MESOS-3718
>     https://issues.apache.org/jira/browse/MESOS-3718
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   src/master/allocator/mesos/hierarchical.hpp 
> cfd937ba306273c24fb5337dfeb1a15e1545169b 
>   src/master/allocator/mesos/hierarchical.cpp 
> f4e4a123d3da0442e8b0b0ad14d1ee760752ba36 
> 
> Diff: https://reviews.apache.org/r/39400/diff/
> 
> 
> Testing
> -------
> 
> make check (Mac OS X 10.10.4)
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>

Reply via email to