-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39400/#review105816
-----------------------------------------------------------



src/master/allocator/mesos/hierarchical.hpp (line 358)
<https://reviews.apache.org/r/39400/#comment164471>

    s/the order the role's/the order that the role's/
    would make this more clear for me.



src/master/allocator/mesos/hierarchical.hpp (line 359)
<https://reviews.apache.org/r/39400/#comment164472>

    s/Quota goes before fair share/Quota comes before fair share/



src/master/allocator/mesos/hierarchical.hpp (line 360)
<https://reviews.apache.org/r/39400/#comment164473>

    s/towards the allocation queue's front./towards the front of the allocation 
queue./



src/master/allocator/mesos/hierarchical.cpp (line 140)
<https://reviews.apache.org/r/39400/#comment164475>

    Maybe s/Introduce/Consider introducing/
    Are we sure we want to do this?



src/master/allocator/mesos/hierarchical.cpp (line 225)
<https://reviews.apache.org/r/39400/#comment164478>

    I think we can add an equivalent comment as above this for loop (not your 
fault):
    `// Update the allocation to this framework.`



src/master/allocator/mesos/hierarchical.cpp (line 330)
<https://reviews.apache.org/r/39400/#comment164483>

    same as above. let's add a comment here.



src/master/allocator/mesos/hierarchical.cpp (line 893)
<https://reviews.apache.org/r/39400/#comment164485>

    let's clarify `just updates the numbers`. Also missing a period.



src/master/allocator/mesos/hierarchical.cpp (line 905)
<https://reviews.apache.org/r/39400/#comment164486>

    A comment as to why we want to `allocate()` here would be useful.



src/master/allocator/mesos/hierarchical.cpp (line 926)
<https://reviews.apache.org/r/39400/#comment164487>

    A comment here would be helpful as well.


- Joris Van Remoortere


On Nov. 5, 2015, 6:25 p.m., Alexander Rukletsov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39400/
> -----------------------------------------------------------
> 
> (Updated Nov. 5, 2015, 6:25 p.m.)
> 
> 
> Review request for mesos, Bernd Mathiske, Joerg Schad, Joris Van Remoortere, 
> and Joseph Wu.
> 
> 
> Bugs: MESOS-3718
>     https://issues.apache.org/jira/browse/MESOS-3718
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   src/master/allocator/mesos/hierarchical.hpp 
> cfd937ba306273c24fb5337dfeb1a15e1545169b 
>   src/master/allocator/mesos/hierarchical.cpp 
> f4e4a123d3da0442e8b0b0ad14d1ee760752ba36 
> 
> Diff: https://reviews.apache.org/r/39400/diff/
> 
> 
> Testing
> -------
> 
> make check (Mac OS X 10.10.4)
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>

Reply via email to