> On Nov. 10, 2015, 9:21 a.m., Joerg Schad wrote: > > src/master/allocator/mesos/hierarchical.hpp, line 359 > > <https://reviews.apache.org/r/39400/diff/5/?file=1109629#file1109629line359> > > > > s/the/this
Re-phrasing it a bit deeper. > On Nov. 10, 2015, 9:21 a.m., Joerg Schad wrote: > > src/master/allocator/mesos/hierarchical.hpp, line 360 > > <https://reviews.apache.org/r/39400/diff/5/?file=1109629#file1109629line360> > > > > Quota is satisfied before fair share, ... Chose different phrasing. > On Nov. 10, 2015, 9:21 a.m., Joerg Schad wrote: > > src/master/allocator/mesos/hierarchical.cpp, line 137 > > <https://reviews.apache.org/r/39400/diff/5/?file=1109630#file1109630line137> > > > > `Resources` This is neither a type, nor an instance, but a proper english word. > On Nov. 10, 2015, 9:21 a.m., Joerg Schad wrote: > > src/master/allocator/mesos/hierarchical.cpp, line 416 > > <https://reviews.apache.org/r/39400/diff/5/?file=1109630#file1109630line416> > > > > `resources` This is neither a type, nor an instance, but a proper english word. > On Nov. 10, 2015, 9:21 a.m., Joerg Schad wrote: > > src/master/allocator/mesos/hierarchical.cpp, line 582 > > <https://reviews.apache.org/r/39400/diff/5/?file=1109630#file1109630line582> > > > > `resources` This is neither a type, nor an instance, but a proper english word. - Alexander ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39400/#review105817 ----------------------------------------------------------- On Nov. 5, 2015, 6:25 p.m., Alexander Rukletsov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39400/ > ----------------------------------------------------------- > > (Updated Nov. 5, 2015, 6:25 p.m.) > > > Review request for mesos, Bernd Mathiske, Joerg Schad, Joris Van Remoortere, > and Joseph Wu. > > > Bugs: MESOS-3718 > https://issues.apache.org/jira/browse/MESOS-3718 > > > Repository: mesos > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/master/allocator/mesos/hierarchical.hpp > cfd937ba306273c24fb5337dfeb1a15e1545169b > src/master/allocator/mesos/hierarchical.cpp > f4e4a123d3da0442e8b0b0ad14d1ee760752ba36 > > Diff: https://reviews.apache.org/r/39400/diff/ > > > Testing > ------- > > make check (Mac OS X 10.10.4) > > > Thanks, > > Alexander Rukletsov > >
