> On Nov. 9, 2015, 1:01 p.m., Till Toenshoff wrote: > > src/hdfs/hdfs.hpp, lines 204-208 > > <https://reviews.apache.org/r/39595/diff/5/?file=1118418#file1118418line204> > > > > The examples of our doxygen-styleguide suggest that we should be using > > C style comments. Same goes with the parameter description which should be > > starting with a capital letter. > > > > ``` > > /** > > * Obtain path modification time. > > * > > * @param path Path to the resource to query. > > * @return Returns the last modification time of the resource in > > seconds > > * since the POSIX epoch, or an Error if it cannot be retrieved. > > */ > > ```
Of course! > On Nov. 9, 2015, 1:01 p.m., Till Toenshoff wrote: > > src/slave/containerizer/fetcher.hpp, line 256 > > <https://reviews.apache.org/r/39595/diff/5/?file=1118419#file1118419line256> > > > > Let's only use the key here... > > > > ``` > > bool hasKey(const std::string& key); > > ``` Done, also a `const` member fct now. - Benjamin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39595/#review105587 ----------------------------------------------------------- On Nov. 10, 2015, 1:45 p.m., Benjamin Bannier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39595/ > ----------------------------------------------------------- > > (Updated Nov. 10, 2015, 1:45 p.m.) > > > Review request for mesos, Bernd Mathiske, Jan Schlicht, and Till Toenshoff. > > > Bugs: MESOS-3785 > https://issues.apache.org/jira/browse/MESOS-3785 > > > Repository: mesos > > > Description > ------- > > Also added function to query mtime of HDFS resource. > > > Diffs > ----- > > src/hdfs/hdfs.hpp 42c150186f2ce676407e4e00e84bd7e38063d9ba > src/slave/containerizer/fetcher.hpp > c7518a36f6344841880dbb11bfce603fd2791fc0 > src/slave/containerizer/fetcher.cpp > 0b676f43e8529c6790824c8cf82e21a81d885ef1 > src/tests/fetcher_cache_tests.cpp 0b3245105b4c1efae54f0bc34f672290819a6f0b > > Diff: https://reviews.apache.org/r/39595/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Benjamin Bannier > >