> On Nov. 10, 2015, 12:52 p.m., Jan Schlicht wrote: > > src/slave/containerizer/fetcher.cpp, line 940 > > <https://reviews.apache.org/r/39595/diff/5/?file=1118420#file1118420line940> > > > > 4 spaces instead of 2 spaces.
It appears that continuations for assignments are indented by 2 spaces, not by 4. Please re-check your version of the C++ style guide. > On Nov. 10, 2015, 12:52 p.m., Jan Schlicht wrote: > > src/slave/containerizer/fetcher.cpp, line 262 > > <https://reviews.apache.org/r/39595/diff/5/?file=1118420#file1118420line262> > > > > Newline after this line please. Fair enough, added an extra newline. - Benjamin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39595/#review105824 ----------------------------------------------------------- On Nov. 10, 2015, 1:45 p.m., Benjamin Bannier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39595/ > ----------------------------------------------------------- > > (Updated Nov. 10, 2015, 1:45 p.m.) > > > Review request for mesos, Bernd Mathiske, Jan Schlicht, and Till Toenshoff. > > > Bugs: MESOS-3785 > https://issues.apache.org/jira/browse/MESOS-3785 > > > Repository: mesos > > > Description > ------- > > Also added function to query mtime of HDFS resource. > > > Diffs > ----- > > src/hdfs/hdfs.hpp 42c150186f2ce676407e4e00e84bd7e38063d9ba > src/slave/containerizer/fetcher.hpp > c7518a36f6344841880dbb11bfce603fd2791fc0 > src/slave/containerizer/fetcher.cpp > 0b676f43e8529c6790824c8cf82e21a81d885ef1 > src/tests/fetcher_cache_tests.cpp 0b3245105b4c1efae54f0bc34f672290819a6f0b > > Diff: https://reviews.apache.org/r/39595/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Benjamin Bannier > >