----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39595/#review105881 -----------------------------------------------------------
Ship it! src/hdfs/hdfs.hpp (lines 205 - 210) <https://reviews.apache.org/r/39595/#comment164565> Indent with an extra space, like ``` /** * Foo * * Bar to describe foo. */ ``` src/hdfs/hdfs.hpp (line 206) <https://reviews.apache.org/r/39595/#comment164564> Each line of a doxygen comment should start with '*'. src/slave/containerizer/fetcher.cpp (line 248) <https://reviews.apache.org/r/39595/#comment164566> Indent with 4 spaces. src/slave/containerizer/fetcher.cpp (line 325) <https://reviews.apache.org/r/39595/#comment164567> Indent with 4 spaces. src/slave/containerizer/fetcher.cpp (line 935) <https://reviews.apache.org/r/39595/#comment164569> Indent with 4 spaces. - Jan Schlicht On Nov. 10, 2015, 2:45 p.m., Benjamin Bannier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39595/ > ----------------------------------------------------------- > > (Updated Nov. 10, 2015, 2:45 p.m.) > > > Review request for mesos, Bernd Mathiske, Jan Schlicht, and Till Toenshoff. > > > Bugs: MESOS-3785 > https://issues.apache.org/jira/browse/MESOS-3785 > > > Repository: mesos > > > Description > ------- > > Also added function to query mtime of HDFS resource. > > > Diffs > ----- > > src/hdfs/hdfs.hpp 42c150186f2ce676407e4e00e84bd7e38063d9ba > src/slave/containerizer/fetcher.hpp > c7518a36f6344841880dbb11bfce603fd2791fc0 > src/slave/containerizer/fetcher.cpp > 0b676f43e8529c6790824c8cf82e21a81d885ef1 > src/tests/fetcher_cache_tests.cpp 0b3245105b4c1efae54f0bc34f672290819a6f0b > > Diff: https://reviews.apache.org/r/39595/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Benjamin Bannier > >
