> On Nov. 1, 2015, 8:14 p.m., Qian Zhang wrote: > > src/master/allocator/mesos/hierarchical.cpp, line 1005 > > <https://reviews.apache.org/r/39401/diff/7/?file=1112398#file1112398line1005> > > > > For this TODO, what do we plan to do in future? Include the dynamic > > reserved resources for this role on this agent in > > ```roleConsumedResources```? And what about the static reserved resources? > > Alexander Rukletsov wrote: > Dynamic reservations should account towards role's quota. [Note about > static > reservations](https://docs.google.com/document/d/16iRNmziasEjVOblYp5bbkeBZ7pnjNlaIzPQqMTHQ-9I/edit?pli=1#heading=h.xumvch9xiky2) > > Qian Zhang wrote: > So when we check if a role's quota is satisfied or not, we will add the > role's allocated resources with the role's dynamically reserved resources, > and check if the sum contains the role's quota. But for role's statically > reserved resources, we will consider they are part of quota. So in future > (after these TODOs are handled) when we check if a role's quota is satified > or not, the formula should be ```(role's allocated resource + role's > dynamically reserved resources) > (role's quota + role's statically reserved > resources)```, right?
Alex, any comments for my question above? :-) - Qian ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39401/#review104656 ----------------------------------------------------------- On Nov. 10, 2015, 6:01 a.m., Alexander Rukletsov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39401/ > ----------------------------------------------------------- > > (Updated Nov. 10, 2015, 6:01 a.m.) > > > Review request for mesos, Bernd Mathiske, Joerg Schad, Joris Van Remoortere, > and Joseph Wu. > > > Bugs: MESOS-3718 > https://issues.apache.org/jira/browse/MESOS-3718 > > > Repository: mesos > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/master/allocator/mesos/hierarchical.cpp > 14fef63714721fcda7cea3c28704766efda6d007 > > Diff: https://reviews.apache.org/r/39401/diff/ > > > Testing > ------- > > make check (Mac OS X 10.10.4) > > > Thanks, > > Alexander Rukletsov > >
