----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39401/#review105865 -----------------------------------------------------------
src/master/allocator/mesos/hierarchical.cpp (line 984) <https://reviews.apache.org/r/39401/#comment164547> laidAside are rejected resources? In that case I would prefer rejectedResources. src/master/allocator/mesos/hierarchical.cpp (line 997) <https://reviews.apache.org/r/39401/#comment164548> s/comes first/is satisfied first src/master/allocator/mesos/hierarchical.cpp (line 1003) <https://reviews.apache.org/r/39401/#comment164552> We can sum up resources as quota is only applicable to scalar resources. src/master/allocator/mesos/hierarchical.cpp (line 1006) <https://reviews.apache.org/r/39401/#comment164554> Wouldn't it make sense to have a flag indicating when quota ia satisfied for the first time in this loop (i.e. foreach slave)? Otherwise we have to recheck this for every agent in the cluster.... - Joerg Schad On Nov. 9, 2015, 10:01 p.m., Alexander Rukletsov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39401/ > ----------------------------------------------------------- > > (Updated Nov. 9, 2015, 10:01 p.m.) > > > Review request for mesos, Bernd Mathiske, Joerg Schad, Joris Van Remoortere, > and Joseph Wu. > > > Bugs: MESOS-3718 > https://issues.apache.org/jira/browse/MESOS-3718 > > > Repository: mesos > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/master/allocator/mesos/hierarchical.cpp > 14fef63714721fcda7cea3c28704766efda6d007 > > Diff: https://reviews.apache.org/r/39401/diff/ > > > Testing > ------- > > make check (Mac OS X 10.10.4) > > > Thanks, > > Alexander Rukletsov > >
