----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39223/#review106038 -----------------------------------------------------------
src/tests/master_quota_tests.cpp (line 288) <https://reviews.apache.org/r/39223/#comment164759> s/We request/Request src/tests/master_quota_tests.cpp (line 320) <https://reviews.apache.org/r/39223/#comment164760> s/We request/Request src/tests/master_quota_tests.cpp (lines 320 - 324) <https://reviews.apache.org/r/39223/#comment164764> I think the one before you create the `Resources` object is better because the `process::http::post()` block is the same in every test. So how about ``` s/We request quota for two different roles./Create a quota request with resources belonging to different roles. ``` and ``` s/Send a quota request with resources belonging to different roles.// ``` ? src/tests/master_quota_tests.cpp (line 336) <https://reviews.apache.org/r/39223/#comment164761> Isn't it safer to use constants here? src/tests/master_quota_tests.cpp (line 342) <https://reviews.apache.org/r/39223/#comment164762> Maybe wrap /master/quota in backticks? src/tests/master_quota_tests.cpp (line 359) <https://reviews.apache.org/r/39223/#comment164763> Formatting. src/tests/master_quota_tests.cpp (line 407) <https://reviews.apache.org/r/39223/#comment164765> s\Resources\a Resources instance Same everywhere below. src/tests/master_quota_tests.cpp (line 415) <https://reviews.apache.org/r/39223/#comment164766> Does this comment add some value here? You haven't used any comments for `process::http::post()` blocks before. src/tests/master_quota_tests.cpp (line 437) <https://reviews.apache.org/r/39223/#comment164767> Again, this comment looks strange here. Moreover, in the combination with the comment for the same block above, it make the reader think this request is not for a specified role. src/tests/master_quota_tests.cpp (line 460) <https://reviews.apache.org/r/39223/#comment164768> Ditto. - Alexander Rukletsov On Nov. 10, 2015, 10:27 p.m., Joerg Schad wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39223/ > ----------------------------------------------------------- > > (Updated Nov. 10, 2015, 10:27 p.m.) > > > Review request for mesos, Alexander Rukletsov, Bernd Mathiske, and Joris Van > Remoortere. > > > Bugs: MESOS-3199 > https://issues.apache.org/jira/browse/MESOS-3199 > > > Repository: mesos > > > Description > ------- > > see Summary. > > > Diffs > ----- > > src/tests/master_quota_tests.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/39223/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Joerg Schad > >
