> On Nov. 13, 2015, 2:23 a.m., Guangya Liu wrote: > > src/tests/master_quota_tests.cpp, lines 201-203 > > <https://reviews.apache.org/r/39223/diff/12/?file=1124301#file1124301line201> > > > > This format may be better? > > https://github.com/apache/mesos/blob/master/src/tests/resources_tests.cpp#L417-L426
Thanks adapted to that style. Maybe we should start a general discussion/add it to the style-guide? - Joerg ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39223/#review106356 ----------------------------------------------------------- On Nov. 15, 2015, 6:05 p.m., Joerg Schad wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39223/ > ----------------------------------------------------------- > > (Updated Nov. 15, 2015, 6:05 p.m.) > > > Review request for mesos, Alexander Rukletsov, Bernd Mathiske, and Joris Van > Remoortere. > > > Bugs: MESOS-3199 > https://issues.apache.org/jira/browse/MESOS-3199 > > > Repository: mesos > > > Description > ------- > > see Summary. > > > Diffs > ----- > > src/tests/master_quota_tests.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/39223/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Joerg Schad > >