-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40168/
-----------------------------------------------------------

Review request for mesos, Jie Yu, Michael Park, and Neil Conway.


Bugs: MESOS-3065
    https://issues.apache.org/jira/browse/MESOS-3065


Repository: mesos


Description
-------

Added 'CreateVolume' and 'DestroyVolume' ACL support to the authorizer.


Diffs
-----

  include/mesos/authorizer/authorizer.hpp 
d667a52f90f970a313580446a5a006cec4b5e25b 
  src/authorizer/local/authorizer.hpp 32de102fd588f029882ef2222121ca83a7410c65 
  src/authorizer/local/authorizer.cpp 6d7da87731a438c2180cf91003e09d4aa5a1c773 
  src/tests/authorization_tests.cpp 4940450193d89a8f11a15d31723119fa26cdab1b 
  src/tests/mesos.hpp 25074a0b8d86b83c5820f7a5a5e10b4ba9efb1ed 

Diff: https://reviews.apache.org/r/40168/diff/


Testing
-------

This is the third in a chain of 6 patches. New tests were added to 
`authorization_tests.cpp` in order to test the authorizer's handling of both 
successful and failed authorization attempts using `ACL::CreateVolume` and 
`ACL::DestroyVolume`. `make check` was used to test after all patches were 
applied.

Note that this chain of patches touches many of the same files as another chain 
beginning with Review #39985 and ending with Review #39989, which is currently 
in review as well. To avoid conflicts, the beginning of this chain begins on 
top of Review #39989.


Thanks,

Greg Mann

Reply via email to