----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40286/#review106423 -----------------------------------------------------------
src/slave/containerizer/mesos/provisioner/docker/puller.hpp (line 79) <https://reviews.apache.org/r/40286/#comment165156> Can we add comments on what the structure is? It would be easy for the reader. src/slave/containerizer/mesos/provisioner/docker/puller.cpp (line 126) <https://reviews.apache.org/r/40286/#comment165160> Log looks a bit illformed. Maybe "Image layer 'xxx' present in staging directory but missing in store. src/slave/containerizer/mesos/provisioner/docker/puller.cpp (line 145) <https://reviews.apache.org/r/40286/#comment165157> We need root preveliges to untar since it could do "mknod" for device files. Maybe we should assert that here. - Jojy Varghese On Nov. 13, 2015, 8:49 a.m., Timothy Chen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40286/ > ----------------------------------------------------------- > > (Updated Nov. 13, 2015, 8:49 a.m.) > > > Review request for mesos and Jojy Varghese. > > > Repository: mesos > > > Description > ------- > > Fix registry puller to return correct rootfs path. > > > Diffs > ----- > > src/slave/containerizer/mesos/provisioner/docker/local_puller.cpp > 2b9daec0de1682f5eaf1b4c0813cab28a0848a7f > src/slave/containerizer/mesos/provisioner/docker/puller.hpp > 4cfbfc32672f97e52ca64b5fe69fda6741b10146 > src/slave/containerizer/mesos/provisioner/docker/puller.cpp > 13f5e2877f4d7951e79ba07073a42848217604b3 > src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp > 8a5691fb55afae305c9d1217341d6b1ceae7bded > > Diff: https://reviews.apache.org/r/40286/diff/ > > > Testing > ------- > > make check and manually test > > > Thanks, > > Timothy Chen > >
