> On Nov. 13, 2015, 3:48 p.m., Jojy Varghese wrote: > > src/slave/containerizer/mesos/provisioner/docker/puller.cpp, line 145 > > <https://reviews.apache.org/r/40286/diff/1/?file=1124945#file1124945line145> > > > > We need root preveliges to untar since it could do "mknod" for device > > files. Maybe we should assert that here.
Linux filesystem isolator requires root to run already, so this is already implied and we don't need to check again anywhere in the provisioner process. - Timothy ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40286/#review106423 ----------------------------------------------------------- On Nov. 13, 2015, 8:49 a.m., Timothy Chen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40286/ > ----------------------------------------------------------- > > (Updated Nov. 13, 2015, 8:49 a.m.) > > > Review request for mesos and Jojy Varghese. > > > Repository: mesos > > > Description > ------- > > Fix registry puller to return correct rootfs path. > > > Diffs > ----- > > src/slave/containerizer/mesos/provisioner/docker/local_puller.cpp > 2b9daec0de1682f5eaf1b4c0813cab28a0848a7f > src/slave/containerizer/mesos/provisioner/docker/puller.hpp > 4cfbfc32672f97e52ca64b5fe69fda6741b10146 > src/slave/containerizer/mesos/provisioner/docker/puller.cpp > 13f5e2877f4d7951e79ba07073a42848217604b3 > src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp > 8a5691fb55afae305c9d1217341d6b1ceae7bded > > Diff: https://reviews.apache.org/r/40286/diff/ > > > Testing > ------- > > make check and manually test > > > Thanks, > > Timothy Chen > >
