----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40286/#review106492 -----------------------------------------------------------
Ship it! This patch looks good to me. We should use putLayer() form local puller to do all those untar work, which also unify the directory rule for puller. As a next step, we should modify the `RegistryClientTest.SimpleRegistryPuller` test to make sure OUTPUT_DIR matchs all rootfs dir in registry puller. (which is currently a failure caused by this patch. - Gilbert Song On Nov. 13, 2015, 8:46 a.m., Timothy Chen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40286/ > ----------------------------------------------------------- > > (Updated Nov. 13, 2015, 8:46 a.m.) > > > Review request for mesos and Jojy Varghese. > > > Repository: mesos > > > Description > ------- > > Fix registry puller to return correct rootfs path. > > > Diffs > ----- > > src/slave/containerizer/mesos/provisioner/docker/local_puller.cpp > 2b9daec0de1682f5eaf1b4c0813cab28a0848a7f > src/slave/containerizer/mesos/provisioner/docker/puller.hpp > 4cfbfc32672f97e52ca64b5fe69fda6741b10146 > src/slave/containerizer/mesos/provisioner/docker/puller.cpp > 13f5e2877f4d7951e79ba07073a42848217604b3 > src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp > 8a5691fb55afae305c9d1217341d6b1ceae7bded > > Diff: https://reviews.apache.org/r/40286/diff/ > > > Testing > ------- > > make check and manually test > > > Thanks, > > Timothy Chen > >
