----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39008/#review106431 -----------------------------------------------------------
Ship it! Thanks! src/files/files.cpp (lines 350 - 351) <https://reviews.apache.org/r/39008/#comment165165> How about: ``` string error = strings::format( "Failed to open file at '%s': %s", resolvedPath.get(), os::strerror(errno)).get(); ``` Ditto below. src/launcher/executor.cpp (lines 48 - 49) <https://reviews.apache.org/r/39008/#comment165166> Whoops, double include? src/linux/routing/link/link.cpp (line 49) <https://reviews.apache.org/r/39008/#comment165168> Per my previous comments, we don't need to introduce os/strerror.hpp includes where we already include os.hpp since it's all encompassing. src/tests/script.cpp (lines 164 - 165) <https://reviews.apache.org/r/39008/#comment165170> Why the wrapping change here? - Ben Mahler On Nov. 12, 2015, 3:27 p.m., Benjamin Bannier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39008/ > ----------------------------------------------------------- > > (Updated Nov. 12, 2015, 3:27 p.m.) > > > Review request for mesos, Bernd Mathiske, Ben Mahler, and Till Toenshoff. > > > Bugs: MESOS-3551 > https://issues.apache.org/jira/browse/MESOS-3551 > > > Repository: mesos > > > Description > ------- > > Switch call sites to using safe strerror_r wrapper. > > > Diffs > ----- > > src/cli/mesos.cpp 80c3c1a7e30e7e148e17c379ec6824ab7e4c0f12 > src/files/files.cpp 08e76b95b632b6fb9c82666550d0ae3c4e1a1a89 > src/launcher/executor.cpp f0d8a21739a52748c2e8d819b2713ae626c1444d > src/linux/routing/link/internal.hpp > 015c0ef5be516d7786c96a96437cced1ae8487fa > src/linux/routing/link/link.cpp 8ea3e31e0f64c7b653f208ec74bb389a702b357a > src/slave/containerizer/docker.cpp 435631d3c4e436906bc7d20830c32d1910fb54fe > src/slave/containerizer/mesos/containerizer.cpp > 38fd8684d11c7a3e0499540bf6458258d58cd2b2 > src/slave/containerizer/mesos/isolators/filesystem/linux.cpp > b0a15d4e9a45c0fb5e3dffe181730df8149cc44f > src/slave/containerizer/mesos/isolators/filesystem/posix.cpp > cc54e905d6c82128a578917de3c91e69d953b23b > src/slave/containerizer/mesos/isolators/filesystem/shared.cpp > 470221121d60d3683c3200bd95d334469deb560c > src/slave/containerizer/mesos/launch.cpp > 09d4d8f4d6837e93a82deef76ca07e2167d6a405 > src/slave/containerizer/mesos/provisioner/backends/bind.cpp > 22ca3c197a90d1f19989b1ed826a22237559583b > src/slave/slave.cpp ac2d0e0153721a66495cd6539b25f5b3cee9d979 > src/tests/containerizer/memory_test_helper.cpp > 8109a4314c0dcf17c5fe124d9b87ac856b3a922a > src/tests/script.cpp d2280c2430db1e051de4d07bf8b04713723fbeb3 > > Diff: https://reviews.apache.org/r/39008/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Benjamin Bannier > >