-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39008/#review103482
-----------------------------------------------------------

Ship it!


LGTM modulo some comments about #includes.


src/cli/mesos.cpp (line 26)
<https://reviews.apache.org/r/39008/#comment161542>

    #include order, please see the comments below.



src/files/files.cpp (line 47)
<https://reviews.apache.org/r/39008/#comment161543>

    same here.



src/launcher/executor.cpp (line 49)
<https://reviews.apache.org/r/39008/#comment161533>

    This file should go at the end of the stout includes ... don't we put 
stout/XX.hpp before stout/DIR/XX.hpp?



src/linux/routing/link/internal.hpp (line 150)
<https://reviews.apache.org/r/39008/#comment161535>

    `#include <stout/os/strerror.hpp>` here too?



src/linux/routing/link/link.cpp (line 300)
<https://reviews.apache.org/r/39008/#comment161534>

    `#include <stout/os/strerror.hpp>` here too?



src/slave/containerizer/isolators/filesystem/posix.cpp (line 24)
<https://reviews.apache.org/r/39008/#comment161537>

    ditto.



src/slave/containerizer/mesos/containerizer.cpp (line 33)
<https://reviews.apache.org/r/39008/#comment161539>

    ditto.



src/slave/containerizer/mesos/launch.cpp (line 27)
<https://reviews.apache.org/r/39008/#comment161538>

    ditto.



src/slave/slave.cpp (line 56)
<https://reviews.apache.org/r/39008/#comment161536>

    Same as above regarding the #include order.



src/tests/containerizer/memory_test_helper.cpp (line 36)
<https://reviews.apache.org/r/39008/#comment161541>

    ditto



src/tests/script.cpp (line 28)
<https://reviews.apache.org/r/39008/#comment161540>

    ditto


- Kapil Arya


On Oct. 12, 2015, 3:09 a.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39008/
> -----------------------------------------------------------
> 
> (Updated Oct. 12, 2015, 3:09 a.m.)
> 
> 
> Review request for mesos, Bernd Mathiske, Ben Mahler, and Till Toenshoff.
> 
> 
> Bugs: MESOS-3551
>     https://issues.apache.org/jira/browse/MESOS-3551
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Switch call sites to using safe strerror_r wrapper.
> 
> 
> Diffs
> -----
> 
>   src/cli/mesos.cpp 80c3c1a7e30e7e148e17c379ec6824ab7e4c0f12 
>   src/files/files.cpp 08e76b95b632b6fb9c82666550d0ae3c4e1a1a89 
>   src/launcher/executor.cpp 50b3c6e319f4b1e08c8ebcdd9f161e19bb14d390 
>   src/linux/routing/link/internal.hpp 
> 015c0ef5be516d7786c96a96437cced1ae8487fa 
>   src/linux/routing/link/link.cpp 8ea3e31e0f64c7b653f208ec74bb389a702b357a 
>   src/slave/containerizer/docker.cpp 174448cc039b316329a8617f488f037a1e640e23 
>   src/slave/containerizer/isolators/filesystem/linux.cpp 
> 8823b7850a1ac17fc4f4868aadf1b04428d2381b 
>   src/slave/containerizer/isolators/filesystem/posix.cpp 
> eec510c4f7655d67b33ad90210eeb57fcc910684 
>   src/slave/containerizer/isolators/filesystem/shared.cpp 
> 73804ca5a8a3bf03e13c74a247b5c21e9af5f040 
>   src/slave/containerizer/mesos/containerizer.cpp 
> b904b2d88e9b62fa4ba312c4569a4d89b0dc6052 
>   src/slave/containerizer/mesos/launch.cpp 
> 09d4d8f4d6837e93a82deef76ca07e2167d6a405 
>   src/slave/containerizer/provisioner/backends/bind.cpp 
> 1fe1746c0bc1c9c12e1378e6438122a91b58316b 
>   src/slave/slave.cpp d1c9977feeb30ad43586a4560eed155865d27a6c 
>   src/tests/containerizer/memory_test_helper.cpp 
> 8109a4314c0dcf17c5fe124d9b87ac856b3a922a 
>   src/tests/script.cpp bcc1fab912410237dfe903d7a36cad9323d625a0 
> 
> Diff: https://reviews.apache.org/r/39008/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Reply via email to