> On Nov. 13, 2015, 10:52 a.m., Neil Conway wrote:
> > src/master/master.cpp, line 3128
> > <https://reviews.apache.org/r/40169/diff/1/?file=1124678#file1124678line3128>
> >
> >     Seems like this change shouldn't be included in this review. i.e., the 
> > state of the tree after any patch in a patch chain should still be correct.

Good call, thanks Neil.


- Greg


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40169/#review106396
-----------------------------------------------------------


On Nov. 13, 2015, 6:30 p.m., Greg Mann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40169/
> -----------------------------------------------------------
> 
> (Updated Nov. 13, 2015, 6:30 p.m.)
> 
> 
> Review request for mesos, Jie Yu, Michael Park, and Neil Conway.
> 
> 
> Bugs: MESOS-3065
>     https://issues.apache.org/jira/browse/MESOS-3065
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added 'Master::authorize{Destroy,Create}Volume' to create/destroy persistent 
> volumes.
> 
> 
> Diffs
> -----
> 
>   src/master/master.hpp ead8520b7108a0f2c3a0bb11ae7b543897d111a2 
>   src/master/master.cpp 7bac0fea4bcd040307fdfdcd002387d5baee46d1 
> 
> Diff: https://reviews.apache.org/r/40169/diff/
> 
> 
> Testing
> -------
> 
> This is the fourth in a chain of 7 patches. `make check` was used to test 
> after all patches were applied.
> 
> Note that this chain of patches touches many of the same files as another 
> chain beginning with Review #39985 and ending with Review #39989, which is 
> currently in review as well. To avoid conflicts, the beginning of this chain 
> begins on top of Review #39989.
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Reply via email to