> On Nov. 16, 2015, 8:02 a.m., Benjamin Bannier wrote: > > 3rdparty/libprocess/3rdparty/Makefile.am, line 216 > > <https://reviews.apache.org/r/40326/diff/1/?file=1125804#file1125804line216> > > > > I think it would make sense to also update the mesos `CMakeLists.txt`.
We should, but it requires some other changes -- we want to do `include_directories(SYSTEM ...)` in CMake, but that isn't trivial because right now all the include paths are collected into a single variable and then passed to `include_directories()`. I'm inclined to leave this for a subsequent patch (CMake still needs fixes for `-Wno-unused-local-typedef` anyway.) > On Nov. 16, 2015, 8:02 a.m., Benjamin Bannier wrote: > > 3rdparty/libprocess/3rdparty/Makefile.am, line 212 > > <https://reviews.apache.org/r/40326/diff/1/?file=1125804#file1125804line212> > > > > I think the emphasis is slightly off here; we aren't working around > > noisy warnings (which are all valid), but the fact that these warnings are > > useless to us as we have no intention of fixing them. I'd also drop the ref > > to the jira issue since it can be reached via the commit message. > > > > How about: > > > > > We use "-isystem" instead of "-I" to add Boost to the include search > > path. This disables compiler warnings inside Boost headers since we have no > > intention of fixing those. Thanks, fixed. I used this text: ```We use "-isystem" instead of "-I" to add Boost to the include search path. This disables compiler warnings inside Boost headers since we can't easily fix them. See MESOS-3799.``` - Neil ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40326/#review106604 ----------------------------------------------------------- On Nov. 16, 2015, 8:47 a.m., Neil Conway wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40326/ > ----------------------------------------------------------- > > (Updated Nov. 16, 2015, 8:47 a.m.) > > > Review request for mesos, Benjamin Bannier and Joris Van Remoortere. > > > Bugs: MESOS-3799 > https://issues.apache.org/jira/browse/MESOS-3799 > > > Repository: mesos > > > Description > ------- > > This instructs the compiler to ignore warnings in the Boost headers. This is > useful, because those headers often contain hard-to-silence warnings that are > not otherwise useful to display. See MESOS-3799. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/Makefile.am > 0adbe539afaf683e4a85582463a2930049a63998 > 3rdparty/libprocess/Makefile.am cdefa37528ea69422978a9772f955042e882dde4 > 3rdparty/libprocess/configure.ac 40801653a7fb9a943dfe33913161d28ef24040c3 > > Diff: https://reviews.apache.org/r/40326/diff/ > > > Testing > ------- > > Re-bootstrapped and tested compilation with Ubuntu Wily and OSX 10.10. > > Note that the cmake build still emits boost-related warnings: I didn't try to > fix this, since cmake emits other warnings that autotools suppresses (e.g., > no-unused-local-typedefs). > > > Thanks, > > Neil Conway > >
