-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40347/#review106662
-----------------------------------------------------------



src/master/master.hpp (line 910)
<https://reviews.apache.org/r/40347/#comment165399>

    Shouldn't this be autherize (similar to authenticate() and the other calls)?



src/master/master.hpp (line 913)
<https://reviews.apache.org/r/40347/#comment165397>

    s/request/set ?



src/master/quota_handler.cpp (line 188)
<https://reviews.apache.org/r/40347/#comment165400>

    Should this be part of the validation below?



src/master/quota_handler.cpp (line 239)
<https://reviews.apache.org/r/40347/#comment165401>

    I see that this is consistent witht the rest of the code, but in my opinion 
the realm should be `Mesos`. If it turns out that this is intended, feel free 
to drop...



src/master/quota_handler.cpp (line 314)
<https://reviews.apache.org/r/40347/#comment165398>

    VLog?



src/master/quota_handler.cpp (line 324)
<https://reviews.apache.org/r/40347/#comment165402>

    validateQuotaInfo would have failed....


- Joerg Schad


On Nov. 16, 2015, 1:53 p.m., Jan Schlicht wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40347/
> -----------------------------------------------------------
> 
> (Updated Nov. 16, 2015, 1:53 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Alexander Rojas, and Till 
> Toenshoff.
> 
> 
> Bugs: MESOS-3862
>     https://issues.apache.org/jira/browse/MESOS-3862
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Quota: Implemented quota request authorization.
> 
> 
> Diffs
> -----
> 
>   include/mesos/quota/quota.proto 4e4d8ccc92e2bf9a8e5eae8488c0c952f82fdd6d 
>   src/master/master.hpp ead8520b7108a0f2c3a0bb11ae7b543897d111a2 
>   src/master/quota_handler.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/40347/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jan Schlicht
> 
>

Reply via email to