> On Nov. 16, 2015, 3:37 p.m., Joerg Schad wrote:
> > src/master/quota_handler.cpp, line 239
> > <https://reviews.apache.org/r/40347/diff/1/?file=1126222#file1126222line239>
> >
> >     I see that this is consistent witht the rest of the code, but in my 
> > opinion the realm should be `Mesos`. If it turns out that this is intended, 
> > feel free to drop...
> 
> Jan Schlicht wrote:
>     Also my opinion! But I'm trying to be consistent with the other 
> `Unauthorized` return values, that all use `Mesos master` as realm. Let's 
> create a ticket and fix it independently from this RR.

A [JIRA ticket](https://issues.apache.org/jira/browse/MESOS-3933) has been 
created.


- Jan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40347/#review106662
-----------------------------------------------------------


On Nov. 16, 2015, 2:53 p.m., Jan Schlicht wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40347/
> -----------------------------------------------------------
> 
> (Updated Nov. 16, 2015, 2:53 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Alexander Rojas, and Till 
> Toenshoff.
> 
> 
> Bugs: MESOS-3862
>     https://issues.apache.org/jira/browse/MESOS-3862
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Quota: Implemented quota request authorization.
> 
> 
> Diffs
> -----
> 
>   include/mesos/quota/quota.proto 4e4d8ccc92e2bf9a8e5eae8488c0c952f82fdd6d 
>   src/master/master.hpp ead8520b7108a0f2c3a0bb11ae7b543897d111a2 
>   src/master/quota_handler.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/40347/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jan Schlicht
> 
>

Reply via email to