-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40347/#review107170
-----------------------------------------------------------



src/master/quota_handler.cpp (lines 201 - 204)
<https://reviews.apache.org/r/40347/#comment166152>

    This is to handle the case where authorization is enabled but 
authentication is disabled. I'm not sure if we could consider this an edge 
case. Having both enabled would make the code much simpler (see revision 3).
    
    FYI: The HTTP "Shutdown Framework" message authorizes only when 
authentication is enabled as well.


- Jan Schlicht


On Nov. 19, 2015, 11:55 a.m., Jan Schlicht wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40347/
> -----------------------------------------------------------
> 
> (Updated Nov. 19, 2015, 11:55 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Alexander Rojas, and Till 
> Toenshoff.
> 
> 
> Bugs: MESOS-3862
>     https://issues.apache.org/jira/browse/MESOS-3862
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Quota: Implemented quota request authorization.
> 
> 
> Diffs
> -----
> 
>   include/mesos/quota/quota.proto 4e4d8ccc92e2bf9a8e5eae8488c0c952f82fdd6d 
>   src/master/master.hpp 5e5a575dc7dd49324f3c837028df8a7f75cd1f80 
>   src/master/quota_handler.cpp 03cef4117c52da7599a2800060f65483ca33bc3f 
> 
> Diff: https://reviews.apache.org/r/40347/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jan Schlicht
> 
>

Reply via email to