----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39492/#review106701 -----------------------------------------------------------
include/mesos/quota/quota.proto (lines 54 - 57) <https://reviews.apache.org/r/39492/#comment165433> I noticed that the other endpoints do not take `QuotaInfo` objects; but instead take a `Resources` custom string/object. Since the internal representation of quota is different than the external representation, are you sure you want to expose the internal representation here? src/master/quota_handler.cpp (lines 191 - 194) <https://reviews.apache.org/r/39492/#comment165434> Consider putting this before the loop: ``` status.mutable_guarantees()->Reserve(master->quotas.size()); ``` - Joseph Wu On Nov. 16, 2015, 5:13 a.m., Joerg Schad wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39492/ > ----------------------------------------------------------- > > (Updated Nov. 16, 2015, 5:13 a.m.) > > > Review request for mesos, Alexander Rukletsov, Bernd Mathiske, and Joris Van > Remoortere. > > > Bugs: MESOS-3073 > https://issues.apache.org/jira/browse/MESOS-3073 > > > Repository: mesos > > > Description > ------- > > Added status handling for quota master endpoint. > Tests are in next Review. > > > Diffs > ----- > > include/mesos/quota/quota.proto 4e4d8ccc92e2bf9a8e5eae8488c0c952f82fdd6d > src/master/master.hpp ead8520b7108a0f2c3a0bb11ae7b543897d111a2 > src/master/quota_handler.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/39492/diff/ > > > Testing > ------- > > Test output: > {"quota":[{"guarantee":{"cpus":4.0,"disk":0,"mem":5.0},"role":"test"}]} > > > Thanks, > > Joerg Schad > >
