> On Nov. 19, 2015, 2:53 p.m., Alexander Rukletsov wrote:
> > src/master/quota_handler.cpp, line 338
> > <https://reviews.apache.org/r/39492/diff/4/?file=1131960#file1131960line338>
> >
> >     s/Status/status
> >     Do you think it makes sense to add `request.body`.
> 
> Joerg Schad wrote:
>     Considered adding request body, but as of right now the body is empty, or?

I'm thinking about the evolution of the request. Maybe it makes sense to add 
URL parameters? Will people be using extra flags? On the other side we can add 
it later. Dropping the issue.


- Alexander


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/39492/#review107176
-----------------------------------------------------------


On Nov. 19, 2015, 3:19 p.m., Joerg Schad wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/39492/
> -----------------------------------------------------------
> 
> (Updated Nov. 19, 2015, 3:19 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Bernd Mathiske, and Joris Van 
> Remoortere.
> 
> 
> Bugs: MESOS-3073
>     https://issues.apache.org/jira/browse/MESOS-3073
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added status handling for quota master endpoint.
> 
> 
> Diffs
> -----
> 
>   include/mesos/quota/quota.proto 4e4d8ccc92e2bf9a8e5eae8488c0c952f82fdd6d 
>   src/master/master.hpp 5e5a575dc7dd49324f3c837028df8a7f75cd1f80 
>   src/master/quota_handler.cpp 03cef4117c52da7599a2800060f65483ca33bc3f 
> 
> Diff: https://reviews.apache.org/r/39492/diff/
> 
> 
> Testing
> -------
> 
> Tests are in next Review.
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>

Reply via email to