> On Nov. 11, 2015, 9:47 p.m., Joseph Wu wrote: > > bootstrap.bat, line 40 > > <https://reviews.apache.org/r/40131/diff/1/?file=1121484#file1121484line40> > > > > `mklink` only works with the Windows command prompt, run as an > > administrator. Is that correct? > > > > (At least, I don't think the command exists in other Windows shells, > > like PowerShell.) > > Alex Clemmer wrote: > That's mostly correct, yes: we do not assume the user has PowerShell > right now, and we do assume the shell running this is `cmd.exe`. > > The symlink thing is a bit more subtle, though: creating symlinks in > general requires the `SeCreateSymbolicLinkPrivilege` privilege, which is by > default only granted to administrators. This need not be the case, though. > > Joseph Wu wrote: > We definitely don't want to assume any specific shell without at least a > comment saying so. If there's some way to detect the shell, that would be > better. (And PowerShell is, by default, installed on Windows nowadays.)
Interesting, it sounds like oyu know some stuff about Windows scripting that I don't. My impression was that if you wanted to make a batch script run in PowerShell, you specifically had to make it (_e.g._) a `.ps1`, and that everything else is assumed to be a batch script meant to be run with `cmd`. Is this wrong? And if it is wrong, how does this affect with our current use of `cmd`-only `.bat` scripts (from what I can tell anyway) such as: https://github.com/apache/mesos/blob/master/3rdparty/libprocess/cmake/macros/VsBuildCommand.bat - Alex ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40131/#review106154 ----------------------------------------------------------- On Nov. 16, 2015, 8:30 a.m., Alex Clemmer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40131/ > ----------------------------------------------------------- > > (Updated Nov. 16, 2015, 8:30 a.m.) > > > Review request for mesos, Artem Harutyunyan, Michael Hopcroft, Joris Van > Remoortere, and Joseph Wu. > > > Repository: mesos > > > Description > ------- > > Windows: Added `bootstrap.bat`, the Windows implementation of `bootstrap`. > > > Diffs > ----- > > bootstrap.bat PRE-CREATION > > Diff: https://reviews.apache.org/r/40131/diff/ > > > Testing > ------- > > > Thanks, > > Alex Clemmer > >
