----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40351/#review106799 -----------------------------------------------------------
src/master/quota_handler.cpp (line 171) <https://reviews.apache.org/r/40351/#comment165575> For ```request.guarantee()```, I think we need to call ```flatten()``` to remove role first. src/master/quota_handler.cpp (line 211) <https://reviews.apache.org/r/40351/#comment165580> For ```offer->resources()```, before doing the math, do we need to call ```flatten()``` to remove role too? For dynamic reservation, in ```Http::_operation()```, I see we do not call ```flatten()``` for offered resources too, is it a bug? - Qian Zhang On Nov. 17, 2015, 12:46 a.m., Alexander Rukletsov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40351/ > ----------------------------------------------------------- > > (Updated Nov. 17, 2015, 12:46 a.m.) > > > Review request for mesos, Bernd Mathiske, Joerg Schad, Joris Van Remoortere, > and Joseph Wu. > > > Bugs: MESOS-3912 > https://issues.apache.org/jira/browse/MESOS-3912 > > > Repository: mesos > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/master/master.hpp dc5790a5f0751f5f4644ef1105a0a0c5b2b30fc1 > src/master/quota_handler.cpp 3db3c55e51470392f72568a768efe8e66fa3dca0 > > Diff: https://reviews.apache.org/r/40351/diff/ > > > Testing > ------- > > make check (Mac OS X 10.10.4) > > > Thanks, > > Alexander Rukletsov > >
