> On Nov. 17, 2015, 2:16 p.m., Qian Zhang wrote: > > src/master/quota_handler.cpp, line 211 > > <https://reviews.apache.org/r/40351/diff/2/?file=1126317#file1126317line211> > > > > For ```offer->resources()```, before doing the math, do we need to call > > ```flatten()``` to remove role too? For dynamic reservation, in > > ```Http::_operation()```, I see we do not call ```flatten()``` for offered > > resources too, is it a bug? > > Alexander Rukletsov wrote: > In this case everything should be fine. IIUC, there is only one reason > why `offer->resources()` has non '*' role: it's a statically reserved > resource. Quota is orthogonal to static reservations, hence we should not > rescind those offers. > > However, I think this check should be removed here. We may rescind more > offers than necessary to satisfy remaining resources (because we want to > rescind from a certain number of agents). I'll think about it.
But I think for the dynamic reserved resource, ```offer->resources()``` also has non * role and also has non-empty ```ReservationInfo```, right? - Qian ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40351/#review106799 ----------------------------------------------------------- On Nov. 18, 2015, 4:15 a.m., Alexander Rukletsov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40351/ > ----------------------------------------------------------- > > (Updated Nov. 18, 2015, 4:15 a.m.) > > > Review request for mesos, Bernd Mathiske, Joerg Schad, Joris Van Remoortere, > and Joseph Wu. > > > Bugs: MESOS-3912 > https://issues.apache.org/jira/browse/MESOS-3912 > > > Repository: mesos > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/master/master.hpp 5e5a575dc7dd49324f3c837028df8a7f75cd1f80 > src/master/quota_handler.cpp 03cef4117c52da7599a2800060f65483ca33bc3f > > Diff: https://reviews.apache.org/r/40351/diff/ > > > Testing > ------- > > make check (Mac OS X 10.10.4) > > > Thanks, > > Alexander Rukletsov > >
