> On Nov. 18, 2015, 3:51 p.m., Qian Zhang wrote: > > src/master/quota_handler.cpp, line 180 > > <https://reviews.apache.org/r/40351/diff/3/?file=1128793#file1128793line180> > > > > Why do we want to rescind the offeres that do not contribute to > > satisfying quota request? > > Alexander Rukletsov wrote: > Because we may rescind more than necessary to satisfy quota request > (remember minimal agent count). If we have a check in place, this will > effectively prevent us from doing so. Does it make sense to you?
Suppose the quota request is to request 20GB disk for a role, and there is an offer which only include 2 CPU & 2GB memory and has no disk resources at all, so we will rescind this offer too? This seems a little unfair to me. And can you please clarify a little more about why we want to rescind offers from at least `numF` agents? The reason is that we want to ensure each framework in that role will have a chance to get an offer in next allocation cycle? - Qian ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40351/#review106977 ----------------------------------------------------------- On Nov. 20, 2015, 1:15 a.m., Alexander Rukletsov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40351/ > ----------------------------------------------------------- > > (Updated Nov. 20, 2015, 1:15 a.m.) > > > Review request for mesos, Bernd Mathiske, Joerg Schad, Joris Van Remoortere, > Joseph Wu, and Qian Zhang. > > > Bugs: MESOS-3912 > https://issues.apache.org/jira/browse/MESOS-3912 > > > Repository: mesos > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/master/master.hpp 5e5a575dc7dd49324f3c837028df8a7f75cd1f80 > src/master/quota_handler.cpp 03cef4117c52da7599a2800060f65483ca33bc3f > > Diff: https://reviews.apache.org/r/40351/diff/ > > > Testing > ------- > > make check (Mac OS X 10.10.4) > > > Thanks, > > Alexander Rukletsov > >
