-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40375/#review106898
-----------------------------------------------------------



include/mesos/mesos.proto (line 651)
<https://reviews.apache.org/r/40375/#comment165704>

    I don't think adding a required field to a protobuf that is sent across the 
wire is backwards compatible. This should be optional with default as 
USAGE_SLACK.


- Vinod Kone


On Nov. 17, 2015, 3:30 a.m., Klaus Ma wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40375/
> -----------------------------------------------------------
> 
> (Updated Nov. 17, 2015, 3:30 a.m.)
> 
> 
> Review request for mesos, Guangya Liu, Artem Harutyunyan, and Joris Van 
> Remoortere.
> 
> 
> Bugs: MESOS-3888
>     https://issues.apache.org/jira/browse/MESOS-3888
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> MESOS-3888: We need to distinguish revocable resource for usage slack and 
> allocation slack.
> 
> 
> Diffs
> -----
> 
>   include/mesos/mesos.proto 5ad48bd 
> 
> Diff: https://reviews.apache.org/r/40375/diff/
> 
> 
> Testing
> -------
> 
> make && make check
> 
> 
> Thanks,
> 
> Klaus Ma
> 
>

Reply via email to