----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39888/#review106929 -----------------------------------------------------------
Ship it! LGTM. 3rdparty/libprocess/3rdparty/stout/include/stout/internal/windows/grp.hpp (line 37) <https://reviews.apache.org/r/39888/#comment165736> Can you add a comment saying that, according to the POSIX spec, returning NULL means that the relevant entry was not found? (And maybe add that on Windows, these things don't exist, so NULL will always be correct.) Ditto for `getpwuid`. - Joseph Wu On Nov. 16, 2015, 1:15 a.m., Alex Clemmer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39888/ > ----------------------------------------------------------- > > (Updated Nov. 16, 2015, 1:15 a.m.) > > > Review request for mesos, Artem Harutyunyan, Michael Hopcroft, Joris Van > Remoortere, and Joseph Wu. > > > Repository: mesos > > > Description > ------- > > This code will be particularly useful when we expand Windows support for > `files/files.hpp`. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/include/Makefile.am > a8c35c086ecae21701f6a720f25231c1b0d4e329 > 3rdparty/libprocess/3rdparty/stout/include/stout/internal/windows/grp.hpp > PRE-CREATION > 3rdparty/libprocess/3rdparty/stout/include/stout/internal/windows/pwd.hpp > PRE-CREATION > 3rdparty/libprocess/3rdparty/stout/include/stout/windows.hpp > 1a7037d64afeedc340258c92067e95d1d3caa027 > > Diff: https://reviews.apache.org/r/39888/diff/ > > > Testing > ------- > > > Thanks, > > Alex Clemmer > >
