----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39888/#review110829 -----------------------------------------------------------
Ship it! 3rdparty/libprocess/3rdparty/stout/include/stout/internal/windows/grp.hpp (line 36) <https://reviews.apache.org/r/39888/#comment170834> this can go on the previous line as per existing pattern in the code base. 3rdparty/libprocess/3rdparty/stout/include/stout/internal/windows/grp.hpp (line 49) <https://reviews.apache.org/r/39888/#comment170829> let's mark the closing of the extern 3rdparty/libprocess/3rdparty/stout/include/stout/internal/windows/pwd.hpp (line 37) <https://reviews.apache.org/r/39888/#comment170835> ditto 3rdparty/libprocess/3rdparty/stout/include/stout/internal/windows/pwd.hpp (line 50) <https://reviews.apache.org/r/39888/#comment170831> let's mark the closing of the extern - Joris Van Remoortere On Dec. 15, 2015, 11:36 p.m., Alex Clemmer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39888/ > ----------------------------------------------------------- > > (Updated Dec. 15, 2015, 11:36 p.m.) > > > Review request for mesos, Artem Harutyunyan, Michael Hopcroft, Joris Van > Remoortere, and Joseph Wu. > > > Repository: mesos > > > Description > ------- > > This code will be particularly useful when we expand Windows support for > `files/files.hpp`. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/include/Makefile.am > d1ef6f0df82e83d8e0d38f7b8986403702519a7d > 3rdparty/libprocess/3rdparty/stout/include/stout/internal/windows/grp.hpp > PRE-CREATION > 3rdparty/libprocess/3rdparty/stout/include/stout/internal/windows/pwd.hpp > PRE-CREATION > 3rdparty/libprocess/3rdparty/stout/include/stout/windows.hpp > 43c85f50958dd9a7ee2ad7c32565585560486c69 > > Diff: https://reviews.apache.org/r/39888/diff/ > > > Testing > ------- > > > Thanks, > > Alex Clemmer > >
