----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40431/#review106998 -----------------------------------------------------------
Patch looks great! Reviews applied: [40431] Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export COMPILER=gcc; ./support/docker_build.sh - Mesos ReviewBot On Nov. 18, 2015, 8:19 a.m., Yong Qiao Wang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40431/ > ----------------------------------------------------------- > > (Updated Nov. 18, 2015, 8:19 a.m.) > > > Review request for mesos, Adam B and Qian Zhang. > > > Bugs: MESOS-3944 > https://issues.apache.org/jira/browse/MESOS-3944 > > > Repository: mesos > > > Description > ------- > > Move RoleInfo message out of allocator.proto > > > Diffs > ----- > > include/mesos/master/allocator.hpp f76118bbf028610c330cebe937d81457fc67a6f3 > include/mesos/master/allocator.proto > 224da71e9f34d2ea11a6e6e235d0f8196abaeb90 > include/mesos/role/role.hpp PRE-CREATION > include/mesos/role/role.proto PRE-CREATION > src/Makefile.am 5aac0ee8657dfca17a232438fd561cb00fd5e752 > src/master/allocator/mesos/allocator.hpp > d2d32af227d66c4030becd4cd64b907a70d25f49 > src/master/allocator/mesos/hierarchical.hpp > 64ccf4164197e59d93d739fa2afbdee2cc2a1d23 > src/master/allocator/mesos/hierarchical.cpp > f2e3b639f210eb06c70584ee7294609d9fd978ad > src/master/master.hpp 5e5a575dc7dd49324f3c837028df8a7f75cd1f80 > src/master/master.cpp 39a0e730b230cee73e30d831ee67d9207359ae28 > src/tests/allocator.hpp e0cb2e75e6cac41ae8d8ed1608f1d64e7c533e34 > src/tests/hierarchical_allocator_tests.cpp > 740cfa801ee90417c038308192d1f4f2416f8315 > > Diff: https://reviews.apache.org/r/40431/diff/ > > > Testing > ------- > > 1. Make Check successfully; > > 2. $ curl http://9.110.48.168:5050/roles > {"roles":[{"frameworks":[],"name":"*","resources":{"cpus":0,"disk":0,"mem":0},"weight":1.0}]} > > > Thanks, > > Yong Qiao Wang > >
