----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40431/#review107903 -----------------------------------------------------------
include/mesos/role/role.proto (line 38) <https://reviews.apache.org/r/40431/#comment167228> I'm thinke whether we need to enhance weight to `int`. Any case that we has to use `double` as weight? If we want to control the scope, TODO is OK. - Klaus Ma On Nov. 25, 2015, 9:57 a.m., Yong Qiao Wang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40431/ > ----------------------------------------------------------- > > (Updated Nov. 25, 2015, 9:57 a.m.) > > > Review request for mesos, Adam B, Guangya Liu, Qian Zhang, and Jian Qiu. > > > Bugs: MESOS-3944 > https://issues.apache.org/jira/browse/MESOS-3944 > > > Repository: mesos > > > Description > ------- > > Move RoleInfo message out of allocator.proto > > > Diffs > ----- > > include/mesos/master/allocator.hpp 619ef01c3a7d640560653cfc1838dd09046d1da0 > include/mesos/master/allocator.proto > 702f56f56c3b1331613cecf26522986f6b572f8c > include/mesos/role/role.hpp PRE-CREATION > include/mesos/role/role.proto PRE-CREATION > src/CMakeLists.txt cfe9d26c45ba42852fd1af958549954e7b04d448 > src/Makefile.am a57e46d06c8c26a32a9444be4f0e1269d775f8b0 > src/master/allocator/mesos/allocator.hpp > 97ee80726ad155917811265a983258b0165d3451 > src/master/allocator/mesos/hierarchical.hpp > 2a21364fdcaa4ec5e5567b9f367c14a1579b9a49 > src/master/allocator/mesos/hierarchical.cpp > aee8ced1fbfec8cf30cb939ff67fadfc6b08f37a > src/master/master.hpp e5e0ed01a56d869cc535687c8dbb6b99f6295b66 > src/master/master.cpp 370980edfc80d1e52134fdaf3ce49177b6528b02 > src/tests/allocator.hpp c7670525765491fe931a4ee38446fa7e9d79af42 > src/tests/hierarchical_allocator_tests.cpp > a45b3dd0a8237fdd080536cb9ab600e71ad939d3 > > Diff: https://reviews.apache.org/r/40431/diff/ > > > Testing > ------- > > 1. Make Check successfully; > > 2. $ curl http://9.110.48.168:5050/roles > {"roles":[{"frameworks":[],"name":"*","resources":{"cpus":0,"disk":0,"mem":0},"weight":1.0}]} > > > Thanks, > > Yong Qiao Wang > >
