----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38117/#review107482 -----------------------------------------------------------
Patch looks great! Reviews applied: [38117] Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export COMPILER=gcc; ./support/docker_build.sh - Mesos ReviewBot On Nov. 20, 2015, 11:25 p.m., Cong Wang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38117/ > ----------------------------------------------------------- > > (Updated Nov. 20, 2015, 11:25 p.m.) > > > Review request for mesos, Jie Yu, Paul Brett, and Vinod Kone. > > > Bugs: MESOS-3365 > https://issues.apache.org/jira/browse/MESOS-3365 > > > Repository: mesos > > > Description > ------- > > These stats are those we get by `netstat -s`, they are important for diagnose > networking issues. > > > Diffs > ----- > > include/mesos/mesos.proto 5ad48bd376c34dd495399b62fa0bd37ddcc5518b > src/slave/containerizer/mesos/isolators/network/port_mapping.hpp > ae53c1b1716a7ad9c6e64f9079c972bae31e4ed2 > src/slave/containerizer/mesos/isolators/network/port_mapping.cpp > e50616fd609588c547c90bba6d7b3b9b3eb4c6a9 > src/slave/flags.hpp 6ae7c94d2e05d81c8b970e7dcaa82d8aa4de7936 > src/slave/flags.cpp 26f554e1a73f1f7f3d7baec7bfc1a7f456c5677c > > Diff: https://reviews.apache.org/r/38117/diff/ > > > Testing > ------- > > ./src/mesos-network-helper statistics --eth0_name=X --enable_snmp_statistics > --pid=XXXX > > > Thanks, > > Cong Wang > >
