----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37853/#review107653 -----------------------------------------------------------
src/slave/containerizer/mesos/provisioner/backends/overlay.hpp (line 33) <https://reviews.apache.org/r/37853/#comment166875> Nit: We usually put the NOTE: beginning of the comment. src/slave/containerizer/mesos/provisioner/backends/overlay.hpp (line 34) <https://reviews.apache.org/r/37853/#comment166876> single images doesn't make much sense to me, I assume you're saying OverlayBackend doesn't support images with a single layer? src/slave/containerizer/mesos/provisioner/backends/overlay.hpp (line 36) <https://reviews.apache.org/r/37853/#comment166877> What's N.B.? To me this is not really a desirable condition for users that has to prep all images to have sandbox_directory created. Can we at least add a TODO to say we want to create it here or somewhere upstream? src/slave/containerizer/mesos/provisioner/backends/overlay.cpp (line 97) <https://reviews.apache.org/r/37853/#comment166881> Should we do this check in create? src/slave/containerizer/mesos/provisioner/backends/overlay.cpp (line 100) <https://reviews.apache.org/r/37853/#comment166879> We use camel case. src/slave/containerizer/mesos/provisioner/backends/overlay.cpp (line 117) <https://reviews.apache.org/r/37853/#comment166882> Let's use layers instead of image here. src/slave/containerizer/mesos/provisioner/backends/overlay.cpp (line 122) <https://reviews.apache.org/r/37853/#comment166883> single quotes around the rootfs variable. src/tests/containerizer/provisioner_backend_tests.cpp (line 55) <https://reviews.apache.org/r/37853/#comment166885> We need to run this in a system where Overlay fs is enabled right? Can we add a check and disable in environment or in the test class? - Timothy Chen On Oct. 28, 2015, 3:58 a.m., Mei Wan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37853/ > ----------------------------------------------------------- > > (Updated Oct. 28, 2015, 3:58 a.m.) > > > Review request for mesos, Ben Mahler, Chi Zhang, Ian Downes, and Jie Yu. > > > Bugs: MESOS-2971 > https://issues.apache.org/jira/browse/MESOS-2971 > > > Repository: mesos > > > Description > ------- > > Implemented the overlay filesystem backend by layering the images as a > read-only filesystem. > > > Diffs > ----- > > src/CMakeLists.txt 6c7519b > src/Makefile.am d6eb302 > src/slave/containerizer/mesos/provisioner/backend.cpp 35ced4b > src/slave/containerizer/mesos/provisioner/backends/overlay.hpp PRE-CREATION > src/slave/containerizer/mesos/provisioner/backends/overlay.cpp PRE-CREATION > src/tests/containerizer/provisioner_backend_tests.cpp 3347d58 > > Diff: https://reviews.apache.org/r/37853/diff/ > > > Testing > ------- > > I haven't done any official testing. When I was working off Ian's branch, I > tested it manually and the provisioning works. > > > Thanks, > > Mei Wan > >
