> On Nov. 23, 2015, 9:50 p.m., Timothy Chen wrote: > > src/slave/containerizer/mesos/provisioner/backends/overlay.hpp, line 36 > > <https://reviews.apache.org/r/37853/diff/8/?file=1110452#file1110452line36> > > > > What's N.B.? > > To me this is not really a desirable condition for users that has to > > prep all images to have sandbox_directory created. Can we at least add a > > TODO to say we want to create it here or somewhere upstream?
To be honest, I'm not too sure what this is. I was actually working off the bind backend code. > On Nov. 23, 2015, 9:50 p.m., Timothy Chen wrote: > > src/slave/containerizer/mesos/provisioner/backends/overlay.cpp, line 97 > > <https://reviews.apache.org/r/37853/diff/8/?file=1110453#file1110453line97> > > > > Should we do this check in create? Makes sense. Moved it to create. - Mei ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37853/#review107653 ----------------------------------------------------------- On Nov. 30, 2015, 1:46 p.m., Mei Wan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37853/ > ----------------------------------------------------------- > > (Updated Nov. 30, 2015, 1:46 p.m.) > > > Review request for mesos, Ben Mahler, Chi Zhang, Ian Downes, and Jie Yu. > > > Bugs: MESOS-2971 > https://issues.apache.org/jira/browse/MESOS-2971 > > > Repository: mesos > > > Description > ------- > > Implemented the overlay filesystem backend by layering the images as a > read-only filesystem. > > > Diffs > ----- > > src/CMakeLists.txt cfe9d26 > src/Makefile.am fd38cfa > src/slave/containerizer/mesos/provisioner/backend.cpp 01d06eb > src/slave/containerizer/mesos/provisioner/backends/overlay.hpp PRE-CREATION > src/slave/containerizer/mesos/provisioner/backends/overlay.cpp PRE-CREATION > src/tests/containerizer/provisioner_backend_tests.cpp 25b28ef > > Diff: https://reviews.apache.org/r/37853/diff/ > > > Testing > ------- > > Basic test in provisioner_backend_tests.cpp. > > > Thanks, > > Mei Wan > >
