-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40431/
-----------------------------------------------------------
(Updated Nov. 30, 2015, 3:11 a.m.)
Review request for mesos, Adam B, Guangya Liu, Qian Zhang, and Jian Qiu.
Bugs: MESOS-3944
https://issues.apache.org/jira/browse/MESOS-3944
Repository: mesos
Description (updated)
-------
Currently role protobuf is defined in allocator.proto due to only the
traditional DRF allocator uses roles as it’s first level of hierarchy, I think
we should move it out and define it in a separated file as quota had in dynamic
roles project, because role protobuf will also be used by master to persist.
Diffs
-----
include/mesos/master/allocator.hpp 619ef01c3a7d640560653cfc1838dd09046d1da0
include/mesos/master/allocator.proto 702f56f56c3b1331613cecf26522986f6b572f8c
include/mesos/role/role.hpp PRE-CREATION
include/mesos/role/role.proto PRE-CREATION
src/CMakeLists.txt cfe9d26c45ba42852fd1af958549954e7b04d448
src/Makefile.am fd38cfa73d81a98c819378f99a766e2ddb7e1a04
src/master/allocator/mesos/allocator.hpp
97ee80726ad155917811265a983258b0165d3451
src/master/allocator/mesos/hierarchical.hpp
1cd8d16661568010901e74705375e7719cdfb8a0
src/master/allocator/mesos/hierarchical.cpp
31ed62efb5b1a2edb567f43d37559c5914e0665e
src/master/master.hpp 96951e766de32842197506504e5ac67a2caa3efe
src/master/master.cpp b918ae4a0e7dc3cd41165fc4b683ae7b6f031821
src/tests/allocator.hpp c7670525765491fe931a4ee38446fa7e9d79af42
src/tests/hierarchical_allocator_tests.cpp
a45b3dd0a8237fdd080536cb9ab600e71ad939d3
Diff: https://reviews.apache.org/r/40431/diff/
Testing
-------
1. Make Check successfully;
2. $ curl http://9.110.48.168:5050/roles
{"roles":[{"frameworks":[],"name":"*","resources":{"cpus":0,"disk":0,"mem":0},"weight":1.0}]}
Thanks,
Yong Qiao Wang
