----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39223/#review108004 -----------------------------------------------------------
src/tests/master_quota_tests.cpp <https://reviews.apache.org/r/39223/#comment167365> Tests for these ones are not implemented yet, mind restoring the item? src/tests/master_quota_tests.cpp (line 186) <https://reviews.apache.org/r/39223/#comment167366> Let's wrap "start" for consistency. Here and below. src/tests/master_quota_tests.cpp (line 189) <https://reviews.apache.org/r/39223/#comment167360> s/http::post/`http::post()` (note backticks) src/tests/master_quota_tests.cpp (lines 198 - 207) <https://reviews.apache.org/r/39223/#comment167361> Let's put these lines into a scope and prepend the scope with the comment you have before `badRequest`. Same for two other sections in this test. src/tests/master_quota_tests.cpp (lines 235 - 260) <https://reviews.apache.org/r/39223/#comment167362> This is covered in the previous test already, right? src/tests/master_quota_tests.cpp (lines 263 - 264) <https://reviews.apache.org/r/39223/#comment167367> How about a one-liner: ``` // Tests a quota request with invalid json fails with '400 Bad Request'. ``` ? src/tests/master_quota_tests.cpp (lines 290 - 291) <https://reviews.apache.org/r/39223/#comment167368> One-liner is possible: ``` // Tests a quota request with multiple roles fails with '400 Bad Request'. ``` src/tests/master_quota_tests.cpp (line 318) <https://reviews.apache.org/r/39223/#comment167369> s/results in an error. Should return a '400 BadRequest' return code./fails with '400 Bad Request'. src/tests/master_quota_tests.cpp (line 340) <https://reviews.apache.org/r/39223/#comment167370> 10 is less than `MIN_MEM`, does it make sense to simply follow the pattern in other tests in this file and use "cpus:1;mem:512;"? src/tests/master_quota_tests.cpp (line 352) <https://reviews.apache.org/r/39223/#comment167372> Why incremental? Let's avoid describing semantics for prohibited operations : ). How about: "Try to repeatedly set quota via POST"? src/tests/master_quota_tests.cpp (lines 378 - 393) <https://reviews.apache.org/r/39223/#comment167373> Again, will it be easier for a reader to understand if you scope this section? - Alexander Rukletsov On Nov. 20, 2015, 9:49 a.m., Joerg Schad wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/39223/ > ----------------------------------------------------------- > > (Updated Nov. 20, 2015, 9:49 a.m.) > > > Review request for mesos, Alexander Rukletsov, Bernd Mathiske, and Joris Van > Remoortere. > > > Bugs: MESOS-3199 > https://issues.apache.org/jira/browse/MESOS-3199 > > > Repository: mesos > > > Description > ------- > > see Summary. > > > Diffs > ----- > > src/tests/master_quota_tests.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/39223/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Joerg Schad > >
