----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40351/#review108038 -----------------------------------------------------------
src/master/quota_handler.cpp (lines 211 - 212) <https://reviews.apache.org/r/40351/#comment167415> How about a `TODO(alexr): Considering only rescinding from agents that have at least 1 resource relevant to the quota request.` src/master/quota_handler.cpp (lines 323 - 327) <https://reviews.apache.org/r/40351/#comment167416> ``` // NOTE: We set quota before we rescind to avoid a race. If we were to // rescind first, then recovered resources may get allocated again // before our call to `setQuota` was handled. // The consequence of setting quota first is that (in the hierarchical // allocator) it will trigger an allocation. This means the rescinded // offer resources will only be available to quota once another // allocation is invoked. // This can be resolved in the future with an explicit allocation call, // and is preferred to having the race described earlier. ``` - Joris Van Remoortere On Nov. 24, 2015, 4:29 p.m., Alexander Rukletsov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40351/ > ----------------------------------------------------------- > > (Updated Nov. 24, 2015, 4:29 p.m.) > > > Review request for mesos, Bernd Mathiske, Joerg Schad, Joris Van Remoortere, > Joseph Wu, and Qian Zhang. > > > Bugs: MESOS-3912 > https://issues.apache.org/jira/browse/MESOS-3912 > > > Repository: mesos > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/master/master.hpp e5e0ed01a56d869cc535687c8dbb6b99f6295b66 > src/master/quota_handler.cpp b8e501be43de6bc02aebfa5bd415b4212a96da31 > > Diff: https://reviews.apache.org/r/40351/diff/ > > > Testing > ------- > > make check (Mac OS X 10.10.4) > > > Thanks, > > Alexander Rukletsov > >
