> On Nov. 22, 2015, 9:50 p.m., Joris Van Remoortere wrote:
> > src/master/quota_handler.cpp, lines 324-328
> > <https://reviews.apache.org/r/40351/diff/5/?file=1132084#file1132084line324>
> >
> >     We should set the quota before we rescind so that we avoid the race 
> > above ;-)
> >     Please add a comment as to why we want to do them in the new order.
> 
> Alexander Rukletsov wrote:
>     Setting quota triggers allocation. I think we would like to rescind 
> *before* we trigger the allocation. If we first set then rescind, rescinded 
> resources may be available only during the next allocation cycle.

Rescinding first and then setting quota gives more flexibility for quota'ed 
frameworks, because in this case the allocator has more resources to allocate, 
which may lead to bigger offers and wider choice for quota'ed frameworks. 
However, the accompanying race is not worth it. Hence we lean towards setting 
quota first and rescinding after. In this case we may have to wait for the 
`allocation_interval` because there is no way to ask the allocator to do a new 
batch allocation after we recover resources from rescinded offers.


- Alexander


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40351/#review107520
-----------------------------------------------------------


On Nov. 24, 2015, 4:29 p.m., Alexander Rukletsov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40351/
> -----------------------------------------------------------
> 
> (Updated Nov. 24, 2015, 4:29 p.m.)
> 
> 
> Review request for mesos, Bernd Mathiske, Joerg Schad, Joris Van Remoortere, 
> Joseph Wu, and Qian Zhang.
> 
> 
> Bugs: MESOS-3912
>     https://issues.apache.org/jira/browse/MESOS-3912
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   src/master/master.hpp e5e0ed01a56d869cc535687c8dbb6b99f6295b66 
>   src/master/quota_handler.cpp b8e501be43de6bc02aebfa5bd415b4212a96da31 
> 
> Diff: https://reviews.apache.org/r/40351/diff/
> 
> 
> Testing
> -------
> 
> make check (Mac OS X 10.10.4)
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>

Reply via email to