-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40351/#review107520
-----------------------------------------------------------



src/master/master.hpp (line 898)
<https://reviews.apache.org/r/40351/#comment166705>

    sat/at the/



src/master/master.hpp (line 903)
<https://reviews.apache.org/r/40351/#comment166706>

    s/as much/as many/
    s/are in/are in the/



src/master/master.hpp (line 905)
<https://reviews.apache.org/r/40351/#comment166707>

    s/increases chances a/increases the chances that a/



src/master/master.hpp (line 908)
<https://reviews.apache.org/r/40351/#comment166708>

    s/but not necessarily happening, remember fair shares/but not guaranteed, 
due to fair sharing)



src/master/quota_handler.cpp (lines 162 - 164)
<https://reviews.apache.org/r/40351/#comment166709>

    Let's drop the `num`. If you really want to be explicit you can postfix 
with `Count`.



src/master/quota_handler.cpp (line 164)
<https://reviews.apache.org/r/40351/#comment166710>

    This suggests we're counting the total number of frameworks with a quota; 
which we are not doing.
    Maybe it's better to call this something like `frameworksInRole`



src/master/quota_handler.cpp (line 180)
<https://reviews.apache.org/r/40351/#comment166711>

    s/at time/at once/



src/master/quota_handler.cpp (lines 180 - 181)
<https://reviews.apache.org/r/40351/#comment166712>

    "Offers that do
      // not contribute to satisfying quota request will be rescinded 
regardless."
      Not sure what you mean here.



src/master/quota_handler.cpp (lines 184 - 186)
<https://reviews.apache.org/r/40351/#comment166713>

    I think `numVA`, and `numVisitedAgents` below should only be incremented 
when we actually have an offer to rescind. Currently we increment it even if 
the agent is packed.



src/master/quota_handler.cpp (lines 211 - 220)
<https://reviews.apache.org/r/40351/#comment166714>

    I don't understand your argument here.
    As long as we set quota before we rescind, the next `allocate` call 
triggered by any rescinded offer will go through the `quota` stage first.



src/master/quota_handler.cpp (lines 324 - 328)
<https://reviews.apache.org/r/40351/#comment166715>

    We should set the quota before we rescind so that we avoid the race above 
;-)
    Please add a comment as to why we want to do them in the new order.


- Joris Van Remoortere


On Nov. 19, 2015, 5:15 p.m., Alexander Rukletsov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40351/
> -----------------------------------------------------------
> 
> (Updated Nov. 19, 2015, 5:15 p.m.)
> 
> 
> Review request for mesos, Bernd Mathiske, Joerg Schad, Joris Van Remoortere, 
> Joseph Wu, and Qian Zhang.
> 
> 
> Bugs: MESOS-3912
>     https://issues.apache.org/jira/browse/MESOS-3912
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   src/master/master.hpp 5e5a575dc7dd49324f3c837028df8a7f75cd1f80 
>   src/master/quota_handler.cpp 03cef4117c52da7599a2800060f65483ca33bc3f 
> 
> Diff: https://reviews.apache.org/r/40351/diff/
> 
> 
> Testing
> -------
> 
> make check (Mac OS X 10.10.4)
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>

Reply via email to