-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40266/
-----------------------------------------------------------
(Updated Dec. 2, 2015, 4:50 p.m.)
Review request for mesos, Artem Harutyunyan and Joris Van Remoortere.
Changes
-------
Addressed one comment. Found and fixed a bug while doing so.
Bugs: MESOS-3910
https://issues.apache.org/jira/browse/MESOS-3910
Repository: mesos
Description
-------
The `SocketManager` and `ProcessManager` are highly inter-dependent, which
requires some untangling in `process::finalize`.
* Logic originally found in `~ProcessManager` has been split into
`ProcessManager::finalize` due to what happens during cleanup.
* Some additional cleanup was added for dangling pointers.
* The future from `__s__->accept()` must be explicitly discarded as libevent
does not detect a locally closed socket.
Diffs (updated)
-----
3rdparty/libprocess/src/process.cpp a7af4671efa2f370137ed4a749e5247c91e6f95e
Diff: https://reviews.apache.org/r/40266/diff/
Testing
-------
`make check` (libev)
`make check` (--enable-libevent --enable-ssl)
Thanks,
Joseph Wu
