> On Dec. 3, 2015, 12:24 p.m., Guangya Liu wrote:
> > src/master/http.cpp, line 385
> > <https://reviews.apache.org/r/40905/diff/1/?file=1152914#file1152914line385>
> >
> >     What about update to 
> >     
> >     Expecting a 'POST' request, received a '" + request.method + "' request"

Do you think it adds extra information?

I think the message is consice and fits in one line. Also technically, 'POST' 
is not a request, it's a method (or http verb).


- Alexander


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40905/#review108813
-----------------------------------------------------------


On Dec. 3, 2015, 11:23 a.m., Alexander Rukletsov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40905/
> -----------------------------------------------------------
> 
> (Updated Dec. 3, 2015, 11:23 a.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, Isabel Jimenez, and Joris Van 
> Remoortere.
> 
> 
> Bugs: MESOS-4056
>     https://issues.apache.org/jira/browse/MESOS-4056
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> According to RFC 2616 
> (http://www.w3.org/Protocols/rfc2616/rfc2616-sec14.html#sec14.7), 
> `MethodNotAllowed` response must include an 'Allow' header containing a list 
> of valid methods.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/include/process/http.hpp 
> c7d19a2086a8891d0198dce1c4d1c92bd99ac6e3 
>   src/master/http.cpp 9097eda47558fb5306af5a61b464937d7ab34e83 
>   src/slave/http.cpp eeebc79f59eb4deff12b1b8bdcd48b62d80f37fc 
>   src/tests/executor_http_api_tests.cpp 
> fe9df1f4d68babaf0960a3b689ffbe60704b8ad5 
>   src/tests/scheduler_http_api_tests.cpp 
> 4f52309ff50a5b56cf20f2c5cfddd9c10b2b75d9 
> 
> Diff: https://reviews.apache.org/r/40905/diff/
> 
> 
> Testing
> -------
> 
> make check (Mac OS X 10.10.4)
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>

Reply via email to