> On Dec. 3, 2015, 12:24 p.m., Guangya Liu wrote: > > src/master/http.cpp, line 385 > > <https://reviews.apache.org/r/40905/diff/1/?file=1152914#file1152914line385> > > > > What about update to > > > > Expecting a 'POST' request, received a '" + request.method + "' request" > > Alexander Rukletsov wrote: > Do you think it adds extra information? > > I think the message is consice and fits in one line. Also technically, > 'POST' is not a request, it's a method (or http verb).
I think that the POST, DELETE, GET, PUT can all be treated as HTTP request ;-) Using "Expecting a 'POST' request, received a '" + request.method + "' request"" does not add extra information, but just make the message clear and official. - Guangya ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40905/#review108813 ----------------------------------------------------------- On Dec. 3, 2015, 2:34 p.m., Alexander Rukletsov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40905/ > ----------------------------------------------------------- > > (Updated Dec. 3, 2015, 2:34 p.m.) > > > Review request for mesos, Anand Mazumdar, Isabel Jimenez, and Joris Van > Remoortere. > > > Bugs: MESOS-4056 > https://issues.apache.org/jira/browse/MESOS-4056 > > > Repository: mesos > > > Description > ------- > > According to RFC 2616 > (http://www.w3.org/Protocols/rfc2616/rfc2616-sec14.html#sec14.7), > `MethodNotAllowed` response must include an 'Allow' header containing a list > of valid methods. > > This is a libprocess change only. > > > Diffs > ----- > > 3rdparty/libprocess/include/process/http.hpp > c7d19a2086a8891d0198dce1c4d1c92bd99ac6e3 > > Diff: https://reviews.apache.org/r/40905/diff/ > > > Testing > ------- > > This a libprocess change only. The code does not compile without the > follow-up [mesos] patch https://reviews.apache.org/r/40913/. > > > Thanks, > > Alexander Rukletsov > >
