----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40905/#review108845 -----------------------------------------------------------
LGTM, Just one minor suggestion + a query regarding why do we need the additional constructor without a `Response` body. 3rdparty/libprocess/include/process/http.hpp (line 582) <https://reviews.apache.org/r/40905/#comment168308> hmmm , why do we need another constructor with no response body ? We have already seen previous bugs from end-users about us not setting `Content-Type` for some error `Response` types like `BadRequest`. Hence, empty body responses should be avoided at best unless I am missing something ? 3rdparty/libprocess/include/process/http.hpp (line 588) <https://reviews.apache.org/r/40905/#comment168307> s/std::vector/std::initializer_list An initializer list is better suited for this constructor since we hardly need any `std::vector` operations. I am assuming `strings::join(...)` plays well with it too ? - Anand Mazumdar On Dec. 3, 2015, 2:34 p.m., Alexander Rukletsov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40905/ > ----------------------------------------------------------- > > (Updated Dec. 3, 2015, 2:34 p.m.) > > > Review request for mesos, Anand Mazumdar, Isabel Jimenez, and Joris Van > Remoortere. > > > Bugs: MESOS-4056 > https://issues.apache.org/jira/browse/MESOS-4056 > > > Repository: mesos > > > Description > ------- > > According to RFC 2616 > (http://www.w3.org/Protocols/rfc2616/rfc2616-sec14.html#sec14.7), > `MethodNotAllowed` response must include an 'Allow' header containing a list > of valid methods. > > This is a libprocess change only. > > > Diffs > ----- > > 3rdparty/libprocess/include/process/http.hpp > c7d19a2086a8891d0198dce1c4d1c92bd99ac6e3 > > Diff: https://reviews.apache.org/r/40905/diff/ > > > Testing > ------- > > This a libprocess change only. The code does not compile without the > follow-up [mesos] patch https://reviews.apache.org/r/40913/. > > > Thanks, > > Alexander Rukletsov > >
