-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40529/#review108874
-----------------------------------------------------------


Looks good.  Just a few nits.


include/mesos/resources.hpp (line 156)
<https://reviews.apache.org/r/40529/#comment168337>

    You should surround `!isPersistentVolume` in backticks.  We use backticks 
for code inside comments.
    
    Same for all copy-pasted comments.



include/mesos/resources.hpp (line 235)
<https://reviews.apache.org/r/40529/#comment168338>

    Note: You have an extra "s" (typo) at the end of `!persistentVolumes`.



src/tests/resources_tests.cpp (lines 1794 - 1798)
<https://reviews.apache.org/r/40529/#comment168339>

    Can you remove some of the newlines here?
    
    Also comment that PersistentVolumes are stateful resources.


- Joseph Wu


On Dec. 2, 2015, 8:35 p.m., Guangya Liu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40529/
> -----------------------------------------------------------
> 
> (Updated Dec. 2, 2015, 8:35 p.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, Joseph Wu, 
> and Klaus Ma.
> 
> 
> Bugs: MESOS-3955
>     https://issues.apache.org/jira/browse/MESOS-3955
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added helper function to get stateless resources.
> 
> 
> Diffs
> -----
> 
>   include/mesos/resources.hpp 9c8bfb0e7e1e40ca99b4cc75079e5b950630243d 
>   include/mesos/v1/resources.hpp db87c992e2ec466cb1d4d17775bf6423a2fb15aa 
>   src/common/resources.cpp 5a7981744726a0544435cbbd5007487a43a01211 
>   src/tests/resources_tests.cpp ce47bac73937a6a608016f46121137d6116c1399 
>   src/v1/resources.cpp d300842576b2fb8fe75f5b18699f23c1fd324717 
> 
> Diff: https://reviews.apache.org/r/40529/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Reply via email to