> On Dec. 4, 2015, 9:48 p.m., Joseph Wu wrote: > > Diana, can you add `hausdorff`, `kaysoky`, `hartem`, and `jvanremoortere` > > to this review (and future CMake reviews)? > > > > --- > > > > Ran `cmake .. && make` on OSX. Hit this error: > > ``` > > mesos/src/slave/containerizer/mesos/linux_launcher.cpp:20:10: fatal error: > > 'linux/sched.h' file not found > > #include <linux/sched.h> > > ``` > > > > Note that `src/Makefile.am` does this: > > ``` > > if OS_LINUX > > libmesos_no_3rdparty_la_SOURCES += $(MESOS_LINUX_FILES) > > else > > EXTRA_DIST += $(MESOS_LINUX_FILES) > > endif > > ``` > > And `linux_launcher.cpp` is in `MESOS_LINUX_FILES`. > > Diana Arroyo wrote: > Reference: "can you add hausdorff, kaysoky, hartem, and jvanremoortere to > this review (and future CMake reviews)?": Done. > Reference: "fatal error: 'linux/sched.h' file not found": working...
Reference: "fatal error: 'linux/sched.h' file not found": Fixed. - Diana ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40951/#review109032 ----------------------------------------------------------- On Dec. 5, 2015, 3:35 a.m., Diana Arroyo wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40951/ > ----------------------------------------------------------- > > (Updated Dec. 5, 2015, 3:35 a.m.) > > > Review request for mesos, Artem Harutyunyan, Alex Clemmer, Joris Van > Remoortere, and Joseph Wu. > > > Bugs: MESOS-3843 > https://issues.apache.org/jira/browse/MESOS-3843 > > > Repository: mesos > > > Description > ------- > > Initial set of source files missing for cmake agent binary. > > > Diffs > ----- > > src/CMakeLists.txt c0d77c745eb5b12dd6d9d7afaba7e820f8d848ef > > Diff: https://reviews.apache.org/r/40951/diff/ > > > Testing > ------- > > Tested to make sure library builds successfully. > > > Thanks, > > Diana Arroyo > >