----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38094/#review104381 -----------------------------------------------------------
3rdparty/libprocess/include/process/authenticator.hpp (line 20) <https://reviews.apache.org/r/38094/#comment168599> Add `#include <stout/hashmap.hpp>` since you are using it. 3rdparty/libprocess/src/authenticator.cpp (line 1) <https://reviews.apache.org/r/38094/#comment168608> License missing - please make sure you include the Apache License Version 2.0 header; ``` // Licensed under the Apache License, Version 2.0 (the "License"); // you may not use this file except in compliance with the License. // You may obtain a copy of the License at // // http://www.apache.org/licenses/LICENSE-2.0 // // Unless required by applicable law or agreed to in writing, software // distributed under the License is distributed on an "AS IS" BASIS, // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. // See the License for the specific language governing permissions and // limitations under the License ``` 3rdparty/libprocess/src/authenticator.cpp (line 28) <https://reviews.apache.org/r/38094/#comment168610> You had added a `using std::string` already, we can kill those `std::` prefixes for references of `string`. 3rdparty/libprocess/src/authenticator.cpp (line 30) <https://reviews.apache.org/r/38094/#comment168604> We commonly derive from clang-format in these cases, the brackets move up; ``` BasicAuthenticator::BasicAuthenticator( const string& realm, const hashmap<std::string, std::string>& credentials) : realm_(realm), credentials_(credentials) {} ``` 3rdparty/libprocess/src/authenticator.cpp (lines 51 - 56) <https://reviews.apache.org/r/38094/#comment168605> Shall we combine those two clauses just like you did below with the credentials check? ``` if (components.size() < 2 || components[0] != "Basic") { return result; } ``` 3rdparty/libprocess/src/tests/http_tests.cpp (line 1407) <https://reviews.apache.org/r/38094/#comment168614> We are `using http::Response` already, kill the namespace. - Till Toenshoff On Dec. 7, 2015, 2:18 p.m., Alexander Rojas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/38094/ > ----------------------------------------------------------- > > (Updated Dec. 7, 2015, 2:18 p.m.) > > > Review request for mesos, Adam B, Benjamin Hindman, Bernd Mathiske, and Till > Toenshoff. > > > Bugs: MESOS-3232 > https://issues.apache.org/jira/browse/MESOS-3232 > > > Repository: mesos > > > Description > ------- > > See summary. > > > Diffs > ----- > > 3rdparty/libprocess/Makefile.am 6ec6d7989df647f466ac6079738835ffcb2ea8ee > 3rdparty/libprocess/include/process/authenticator.hpp > 5a32e9a38a0bec7aa3faef23b792f3bf3d659d4f > 3rdparty/libprocess/src/CMakeLists.txt > 681f0cfec57e152568da41698c8bdd52c05f65a6 > 3rdparty/libprocess/src/authenticator.cpp PRE-CREATION > 3rdparty/libprocess/src/tests/http_tests.cpp > 2de75ca1c7e224c36b534c368e7379dc158aa5bb > > Diff: https://reviews.apache.org/r/38094/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Alexander Rojas > >
