> On Dec. 8, 2015, 12:17 a.m., Joseph Wu wrote:
> > LGTM!
> > 
> > One question: Is the positive case (correct role -> successful operation) 
> > not interesting or just tested in other files?

There are tests for successful cases in other files. Maybe not exhaustive 
though...


- Neil


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40995/#review109217
-----------------------------------------------------------


On Dec. 7, 2015, 9:22 p.m., Neil Conway wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40995/
> -----------------------------------------------------------
> 
> (Updated Dec. 7, 2015, 9:22 p.m.)
> 
> 
> Review request for mesos, Adam B, Alexander Rukletsov, Greg Mann, and Yong 
> Qiao Wang.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added test cases for role behavior.
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am e96e0ec41e11acff00fbfb3e86427b48a0625bd2 
>   src/tests/reservation_tests.cpp 3fdf5e121840fe99057e917cca48f1425eff6624 
>   src/tests/role_tests.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/40995/diff/
> 
> 
> Testing
> -------
> 
> make check.
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Reply via email to